Repository navigation
[Chore] Run webview CI tests with four workers (#2288) - #2308
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
|
No code issues found. See session Reviewed 64d59c9 |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: The required review sequence passed. Remaining merge requirements apply. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Related GitHub Issue
Closes: #2288
Description
The webview CI Vitest run now uses four workers on hosted runners. The previous budget was one worker. The change is one line in
webview-ui/vitest.config.ts:maxWorkers: isCI ? 4 : undefined(wasisCI ? 1 : undefined). The setting applies only whenCI=true, so it covers the measured Ubuntu and Windows hosted runner classes. Local (non-CI) runs stay unchanged.Forks, isolation, assertions, coverage,
onConsoleLoghandling, and CI test timeouts are unchanged. The defaultforkspool stays in place. No benchmark harness is included in this PR. Vitest stays at 4.1.12. No errors are suppressed.Benchmark
From #2288 (GitHub-hosted benchmark, commit
86197abe, Node 22.23.4 / Vitest 4.1.12, two repetitions per setting, 174 files / 2,269 tests, no retries):Local Linux spot-check for this PR (18 vCPU,
CI=true): thesrc/componentssubset (147 files / 1,799 tests) took 235.8s with--max-workers=1and 108.9s with the new four-worker config.Once CI runs on this PR, compare test-step duration, job duration, runner minutes, and time until required checks turn green against
main. Two repetitions do not establish reliability or p95.Rollback
Revert the worker budget to one worker. Change
maxWorkers: isCI ? 4 : undefinedback tomaxWorkers: isCI ? 1 : undefinedinwebview-ui/vitest.config.ts, or revert this commit. No other cleanup is required.Test Procedure
CI=true pnpm turbo run test:coverage --filter=@roo-code/vscode-webview: 181 files / 2,333 tests passed, 133.1s (full inventory with coverage, four workers, Linux).src/componentssubset with--max-workers=1vs the new config: 235.8s vs 108.9s.pnpm --filter @roo-code/vscode-webview lint: pass.pnpm --filter @roo-code/vscode-webview check-types: pass.pnpm exec prettier --check webview-ui/vitest.config.ts: pass.pnpm test: pass on rerun (14/14 Turbo tasks). One earlier run had two failures insrc/__tests__/extension.spec.tsunder heavy parallel load. That file passes 24/24 in isolation. The failures are unrelated to this change.platform-unit-testjobs of the Code QA workflow on this PR.Pre-Submission Checklist
Visual Snapshots
Not applicable. This change does not alter rendered UI.
Videos (interaction / animation only)
Not applicable.
Documentation Updates
Additional Notes
Issue #2288 notes a rare Ubuntu teardown error,
Closing rpc while "onUserConsoleLog" was pending, seen once in twelve benchmark repetitions. The upstream fix ships in Vitest 5.1.0-beta.1. This repo uses Vitest 4.1.12. That issue is tracked separately and is not addressed here.Get in Touch
0x7777777_